-
Notifications
You must be signed in to change notification settings - Fork 84
Refactor race warnings (accesses) to use global invariant #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix top thread ID set issues from sv-benchmarks
Mutex analysis already computes these anyway.
This was referenced Oct 14, 2021
Merged
Member
Author
|
Merging into the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #368 for race warnings, which aren't done the usual way: they don't appear during individual transfer functions.
These changes could apply to
masterdirectly, but since they're just necessary for interactive race warnings, this PR is againstinteractive, where there are incremental warnings at all.Changes
sidegand deeply nested map domains instead of using a OCaml global deeply nested hashtable. Having this in the actual constraint system and its solution makes it easier to do incremental accesses/race warnings.sidegduring postsolving to modify the solution. This is a massive hack, but since accesses are only collected at the end, this is the only way to have them added into the solution. To make verify happy,leqof the access analysis global domain is constant true (it's only collected during postsolving anyway). The alternative would be to expose a pair of domains through all the specs, constraint systems and solvers to allow the second warning-collecting component to be handled separately.WarnGlobalquery to emit warnings for globals at the end of solving. Since race warnings are based on the accesses collected into the global invariant during postsolving, this needs to be done per-global after postsolving.TODO
__NONE__varinfo, which is initialized toG.bot (), and currentlyset_startoverwrites with this during incremental load. Hopefully Incremental TD3: fix start variables #393 fixes this.